On Wed, 14 Jun 2023 20:17:32 GMT, Alexey Ivanov <[email protected]> wrote:
> After the size of `ScrollPane` child component changes, it recalculates the > size of the scroll bars and hides or shows them as necessary. This situation > is handled in `WScrollPanePeer.childResized`: > > https://github.com/openjdk/jdk/blob/ee4ab6709ebaf8a1b1e9f297a7c53205987f3eba/src/java.desktop/windows/classes/sun/awt/windows/WScrollPanePeer.java#L104-L109 > > After [JDK-8297923](https://bugs.openjdk.org/browse/JDK-8297923), `setSpans` > is run asynchronously on the toolkit thread. Thus, `setInsets` calculates the > incorrect values because `setSpans` hasn't updated the sizes yet. > > This is a regression from > [JDK-8297923](https://bugs.openjdk.org/browse/JDK-8297923). > > **Fix** > > The insets are updated in the native implementation of `setSpans` directly. > > The native implementation of `setInsets` method is run on the toolkit thread > as a synchronous call because the insets are used in > [`WScrollPanePeer.initialize`](https://github.com/openjdk/jdk/blob/ee4ab6709ebaf8a1b1e9f297a7c53205987f3eba/src/java.desktop/windows/classes/sun/awt/windows/WScrollPanePeer.java#L62-L67). This pull request has now been integrated. Changeset: d6c2ee34 Author: Alexey Ivanov <[email protected]> URL: https://git.openjdk.org/jdk/commit/d6c2ee3448a14b3e5a392aacc11ed8e47d388f80 Stats: 13 lines in 3 files changed: 7 ins; 1 del; 5 mod 8310054: ScrollPane insets are incorrect Reviewed-by: honkar, prr ------------- PR: https://git.openjdk.org/jdk/pull/14478
