On Wed, 21 Jun 2023 05:32:46 GMT, Julian Waters <jwat...@openjdk.org> wrote:

>> In windowsaccessbridge(-64).dll the following methods are exported in a def 
>> file to C API which in turn call their real implementation, which are 
>> instance methods of the class WinAccessBridge:
>> 
>> addJavaEventNotification
>> removeJavaEventNotification
>> addAccessibilityEventNotification
>> removeAccessibilityEventNotification
>> 
>> 
>> However, they are nowhere to be seen in the actual C interface, in 
>> AccessBridgeWindowsEntryPoints.cpp. Your guess is as good as mine as to how 
>> on earth MSVC is still capable of compiling and linking this without any 
>> errors whatsoever, but in any case, this is a severe oversight and should be 
>> properly defined in the C API lest this happy accident within MSVC is fixed 
>> by Microsoft in the future
>
> Julian Waters has updated the pull request incrementally with three 
> additional commits since the last revision:
> 
>  - Revert AccessBridgeWindowsEntryPoints.h
>  - Remove from WinAccessBridge.DEF
>  - Revert AccessBridgeWindowsEntryPoints.cpp

Ah, sorry about that. I've had several changes starved of reviews recently and 
lying around for almost a month, and was feeling fairly frustrated and 
impatient :(

-------------

PR Comment: https://git.openjdk.org/jdk/pull/13734#issuecomment-1600612951

Reply via email to