On Mon, 3 Jul 2023 04:45:38 GMT, Abhishek Kumar <[email protected]> wrote:
>> Harshitha Onkar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> kCGEventFlagMaskSecondaryFn added
>
> src/java.desktop/macosx/native/libawt_lwawt/awt/CRobot.m line 426:
>
>> 424: }
>> 425:
>> 426: static inline int GetCGKeyMask(int cgKeyCode)
>
> Suggestion:
>
> static inline int GetCGKeyMask(int cgKeyCode) {
I disagree: the common style throughout this file is to put the opening brace
on the following line. A few lines above, `GetCGKeyCode` follows the same style.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14744#discussion_r1251261953