On Mon, 10 Jul 2023 20:40:45 GMT, Jiangli Zhou <[email protected]> wrote:
>> Please review this trivial PR that changes read_icc_profile() to static >> function to avoid static linking failure due to duplicate symbol issue. > > Jiangli Zhou has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains three additional > commits since the last revision: > > - Merge branch 'master' into JDK-8311606 > - Merge branch 'master' into JDK-8311606 > - JDK-8311606: Change read_icc_profile() to static function in > java.desktop/share/native/libjavajpeg/imageioJPEG.c I'm reading the bug report and I want to understand this better. Why is this function in particular a problem ? What is special about it vs many others ? You wrote "when statically linking with JDK." Which would mean statically linking this code (in the JDK) with another JDK ? What exactly is this scenario. And you say 'potential problem'. Have you seen an 'actual problem' ? You hint at 'a certain jpeg library'. ------------- PR Comment: https://git.openjdk.org/jdk/pull/14794#issuecomment-1629754021
