On Thu, 29 Jun 2023 13:35:20 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:

>> I think it is not needed to return 1 from `getAccessibleChildrenCount(...)`. 
>>  `getAccessibleChildrenCount(...)` is used to get the exact number of 
>> accessible child for a component and afterwards `getAccessibleChild(..., 
>> index)` method can be invoked to get the child.
>> 
>> It should be ok to return null if the switch case condition fails or index 
>> doesn't match with case statement. Although chances of returning null is 
>> very unlikely for index 0 and 1.
>
> I tend to agree… there are now two children; if the condition in 
> `getAccessibleChild` fails, it returns `null`. Nothing has changed, there's a 
> possibility that it would return `null`. Yet it shouldn't because both editor 
> and button implement `Accessible`.

please double-check how it will work in Windows, it might be possible that jaws 
expects 1.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14497#discussion_r1268842174

Reply via email to