On Fri, 23 Jun 2023 20:24:21 GMT, Alisen Chung <[email protected]> wrote:

>> added displayChanged call to CPlatformWindow when frame first needs to 
>> deiconify or unmaximize
>> All client tests passed after change
>
> Alisen Chung has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   added test cases, fixed spacing

src/java.desktop/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java line 989:

> 987:             synchronized (lock) {
> 988:                 try {
> 989:                     lock.wait();

Are we sure that waiting forever is a good thing? Can this request be ignored 
by the OS for any reason?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14226#discussion_r1271610554

Reply via email to