On Fri, 28 Jul 2023 07:43:26 GMT, Aleksey Shipilev <[email protected]> wrote:
>> make/modules/java.desktop/lib/Awt2dLibraries.gmk line 248:
>>
>>> 246: DISABLED_WARNINGS_gcc_OGLBufImgOps.c := format-nonliteral, \
>>> 247: DISABLED_WARNINGS_gcc_OGLPaints.c := format-nonliteral, \
>>> 248: DISABLED_WARNINGS_gcc_screencast_pipewire.c := undef, \
>>
>> At least ignoring it just for the specific compilation units is not too bad.
>>
>> I'll approve but I'd like to see a comment here as to why its needed - ie
>> just for gcc6 so people have an idea when we might be able to remove it and
>> know not to remove it because it doesn't matter for the current compiler
>> version.
>>
>> I've still asked upstream to consider applying your first version so that
>> we'd not need this although perhaps it won't matter for long .. once no one
>> cares about gcc6 because we need to move on for other reasons.
>
> There is no good way to put the comment straight into this block, AFAICS. Can
> we settle on repository history to tell future investigations why this was
> added?
How about using a variable with a useful name? e.g.:
`DISABLED_FOR_NOT_COMPLETE_COMPILER_CHECK := undef`
...
DISABLED_WARNINGS_gcc_OGLPaints.c := format-nonliteral, \
DISABLED_WARNINGS_gcc_screencast_pipewire.c :=
$(DISABLED_FOR_NOT_COMPLETE_COMPILER_CHECK), \
DISABLED_WARNINGS_gcc_screencast_portal.c :=
$(DISABLED_FOR_NOT_COMPLETE_COMPILER_CHECK), \
DISABLED_WARNINGS_gcc_sun_awt_X11_GtkFileDialogPeer.c := parentheses, \
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14995#discussion_r1277421170
