On Tue, 1 Aug 2023 04:10:55 GMT, Renjith Kannath Pariyangad <[email protected]> wrote:
>> Hi Reviewers, >> >> Observations : >> 1. Without com initialize if we access Mixer for recording, library loaded >> invalid GUID and clipped description in windows(ID not found in registry). >> With com initialization library load proper GUID (same as registry). >> 2. For Play back device always loading proper device GUID irrespective of >> com Initialization. >> >> Test: >> Since screen lock and unlock workflow required for reproducing this issue, >> did coupe of iteration of manual testing post fix and confirmed its >> resolving the problem. >> To reconfirm nothing is broken, executed all audio related test cases on >> test bench post fix and all are green. >> >> Please review the changes and let me know your comments if any. >> >> Regards, >> Renjith. > > Renjith Kannath Pariyangad has updated the pull request incrementally with > one additional commit since the last revision: > > Added CoInitialize status check Did further investigation on JDK-7116070 (name truncation issue) and found its [MS structure](https://learn.microsoft.com/en-us/windows-hardware/drivers/audio/extended-capabilities-from-a-wdm-audio-driver) limitation, this structure can accommodate max 31 char only for _szPname_ . Workflow : **PLATFORM_API_WinOS_Ports.c** loading the description with the help of _mixerGetDevCapsW_ function and result will be stored into the [MIXERCAPSW](https://learn.microsoft.com/en-us/windows/win32/api/mmeapi/ns-mmeapi-mixercapsw) structure and in this max size for _szPname_ is 31 char. ------------- PR Comment: https://git.openjdk.org/jdk/pull/14898#issuecomment-1659538888
