On Wed, 2 Aug 2023 06:36:46 GMT, Prasanta Sadhukhan <[email protected]> wrote:
>> Tejesh R has updated the pull request with a new target base due to a merge >> or a rebase. The incremental webrev excludes the unrelated changes brought >> in by the merge/rebase. The pull request contains 14 additional commits >> since the last revision: >> >> - Review fix >> - Merge branch 'master' of https://git.openjdk.java.net/jdk into >> branch_8311031 >> - Review fix >> - Review fix >> - Review fix >> - Review fix >> - Review fix >> - Review fix >> - Review comment fix >> - Updated based on review comments >> - ... and 4 more: https://git.openjdk.org/jdk/compare/dff82114...3e76abaa > > test/jdk/javax/swing/JTableHeader/TableHeaderBorderPositionTest.java line 99: > >> 97: saveBufferedImage(bufferedImage, "failureImage.png"); >> 98: throw new RuntimeException("Test Failed at <" + x + >> ", " + y + ">"); >> 99: } > > Ideally this failure check should be done outside EDT else I think you will > get InvocationTargetException instead of RuntimeException It's not necessary, especially when it complicates the test logic. Our CI displays the cause of `InvocationTargetException`, so you get the failure message. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/14766#discussion_r1281786623
