On Thu, 17 Aug 2023 18:09:26 GMT, Phil Race <[email protected]> wrote:
>> ScientificWare has updated the pull request incrementally with one >> additional commit since the last revision: >> >> StyleSheet.java : Adds missing space in some if statements > > As mentioned earlier in this review, you need to absorb the changes in > https://github.com/openjdk/jdk/pull/10317/ > into THIS PR and withdraw 10317. > @prrace > > Do I absorb the changes in #15262 too ? If the changes in #15262 require updating the specification , then please absorb it too. I haven't looked into the changes there. You're modifying how `rgb()` and `rgba()` CSS functions parse colours. Do these functions affect the result that you get from `StyleSheet.stringToColor`? If yes, then it has to be absorbed. Both #9825 (this PR) and #10317 modify the behaviour of `StyleSheet.stringToColor` which is a public API, therefore changing its behaviour requires a CSR. It's better to review the behavioural changes once so that both cases are handled at the same time: named colours as well as hex parsing. ------------- PR Comment: https://git.openjdk.org/jdk/pull/9825#issuecomment-1682806455
