On Thu, 31 Aug 2023 07:17:35 GMT, Tejesh R <[email protected]> wrote:
>> On `NewFolderAction`, plain String is added `Action.ACTION_COMMAND_KEY`.
>> Converting the `String `to `locale` before adding as command key fix the
>> issue.
>> I have verified the test in all other platforms and Look and Feel which has
>> option to create New Folder, results were fine. No regressions found on CI
>> system with the fix. Added manual test to verify the fix.
>
> Tejesh R has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Review fix
test/jdk/javax/swing/JFileChooser/FileChooserNewFolderLocaleTest.java line 71:
> 69:
> fileChooser.getFileSystemView().createNewFolder(currentDir);
> 70: if(!newFolderFrench.getName().contains(FRENCH_NEW_FOLDER)) {
> 71: throw new RuntimeException("Failed to update French
> Locale");
Suggestion:
throw new RuntimeException("Failed to update to French Locale");
test/jdk/javax/swing/JFileChooser/FileChooserNewFolderLocaleTest.java line 77:
> 75: System.out.println("Failed to delete file : " +
> 76: newFolderEnglish.getName());
> 77: }
It's a bit on the overthinking side yet you use the same code for both
`newFolderEnglish` and `newFolderFrench`. A helper method to remove the folder
and to print an error message would eliminate the duplicate code.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15069#discussion_r1311694954
PR Review Comment: https://git.openjdk.org/jdk/pull/15069#discussion_r1311698554
