On Tue, 12 Sep 2023 20:26:42 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:
>> Alexander Zvegintsev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> spacing
>
> test/jdk/java/awt/Choice/ChoiceSelectTest.java line 39:
>
>> 37:
>> 38: public class ChoiceSelectTest extends Panel {
>> 39: Choice c;
>
> Can be `final`?
Sure.
> test/jdk/java/awt/Choice/ChoiceSelectTest.java line 160:
>
>> 158: public static void main(String[] args) throws Exception {
>> 159: EventQueue.invokeAndWait(() -> new ChoiceSelectTest().test());
>> 160: }
>
> The choice is never shown on the screen, is it? Can the test be headless then?
No, it can't, Choice is heavyweight component:
https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/java/awt/Choice.java#L116
> test/jdk/java/awt/geom/HitTest/PathHitTestManual.java line 114:
>
>> 112: public static class PathHitTestCanvas extends Canvas implements
>> Runnable {
>> 113: public static final Color[] colors = {
>> 114: /* contains? point in? intersects? */
>
> Should this line align to Yes / No comments below?
Fixed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15671#discussion_r1323602150
PR Review Comment: https://git.openjdk.org/jdk/pull/15671#discussion_r1323602446
PR Review Comment: https://git.openjdk.org/jdk/pull/15671#discussion_r1323605213
