On Mon, 18 Sep 2023 14:10:01 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review comments changes
>
> test/jdk/javax/swing/JTree/bug4213868.java line 54:
>
>> 52: JTree parent = createTree();
>> 53: AccessibleContext c = parent.getAccessibleContext()
>> 54: .getAccessibleChild(0).getAccessibleContext();
>
> Suggestion:
>
> AccessibleContext c = parent.getAccessibleContext()
> .getAccessibleChild(0)
> .getAccessibleContext();
Added the newlines and alignments, thanks
> test/jdk/javax/swing/JTree/bug4213868.java line 56:
>
>> 54: .getAccessibleChild(0).getAccessibleContext();
>> 55: if (c.getAccessibleChild(1).getAccessibleContext()
>> 56: .getAccessibleIndexInParent() != 1) {
>
> Suggestion:
>
> if (c.getAccessibleChild(1)
> .getAccessibleContext()
> .getAccessibleIndexInParent() != 1) {
>
> However, it doesn't look as good as the above.
Added the newlines and alignments, thanks
> test/jdk/javax/swing/JTree/bug4224491.java line 43:
>
>> 41:
>> 42: public static void main(String[] args) throws InterruptedException,
>> 43: InvocationTargetException {
>
> Suggestion:
>
> public static void main(String[] args) throws Exception {
Updated where applicable
> test/jdk/javax/swing/JTree/bug4237370.java line 56:
>
>> 54: }
>> 55:
>> 56: public void treeExpanded (TreeExpansionEvent e) {
>
> Suggestion:
>
> public void treeExpanded(TreeExpansionEvent e) {
Fixed
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15756#discussion_r1329163276
PR Review Comment: https://git.openjdk.org/jdk/pull/15756#discussion_r1329163175
PR Review Comment: https://git.openjdk.org/jdk/pull/15756#discussion_r1329162846
PR Review Comment: https://git.openjdk.org/jdk/pull/15756#discussion_r1329162574
