On Mon, 18 Sep 2023 23:30:26 GMT, Damon Nguyen <dngu...@openjdk.org> wrote:
>> These are the tests being converted:
>>
>> javax/swing/JToolBar/4138694/bug4138694.java
>> javax/swing/JToolBar/4140421/bug4140421.java
>> javax/swing/JToolBar/4196662/bug4196662.java
>> javax/swing/JToolBar/4243930/bug4243930.java
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update constant name
Changes requested by aivanov (Reviewer).
test/jdk/javax/swing/JToolBar/bug4243930.java line 44:
> 42: private static class NullAction extends AbstractAction {
> 43: public void actionPerformed(ActionEvent e){}
> 44: }
Suggestion:
/**
* Auxiliary class implementing Action
*/
private static class NullAction extends AbstractAction {
public void actionPerformed(ActionEvent e) {}
}
Align the javadoc to class declaration.
In a way, the comment is redundant, the purpose is clearly seen from the usage.
test/jdk/javax/swing/JToolBar/bug4243930.java line 47:
> 45:
> 46: public static void main(String[] argv) throws InterruptedException,
> 47: InvocationTargetException {
Suggestion:
public static void main(String[] argv) throws Exception {
This one hasn't been updated.
-------------
PR Review: https://git.openjdk.org/jdk/pull/15748#pullrequestreview-1632917786
PR Review Comment: https://git.openjdk.org/jdk/pull/15748#discussion_r1329898922
PR Review Comment: https://git.openjdk.org/jdk/pull/15748#discussion_r1329899856
