On Wed, 20 Sep 2023 06:16:21 GMT, Prasanta Sadhukhan <[email protected]> wrote:
>> Abhishek Kumar has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Removed unused robot instance > > test/jdk/javax/swing/JButton/bug4234034.java line 64: > >> 62: robot.keyPress(KeyEvent.VK_F1); >> 63: robot.keyRelease(KeyEvent.VK_F1); >> 64: robot.keyRelease(KeyEvent.VK_CONTROL); > > there is no failure check...what should happen with ctrl+F1 without the fix, > will it crash? It should throw `NullPointerException`. It was fixed in 1.3.0 and affects 1.2.0 I tried checking modified test with 1.2.1 but it seems **Robot is available since 1.3**, getting compile error. Didn't get 1.2.0 binary. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/15835#discussion_r1331361541
