On Tue, 8 Aug 2023 08:44:25 GMT, Sergei Tachenov <[email protected]> wrote:

> Hello!
> 
> I'm a member of the UI team in JetBrains IntelliJ department, and we have 
> this bug with popup menus being shown on the wrong monitor in multi-monitor 
> environments:
> 
> https://youtrack.jetbrains.com/issue/JBR-5824/Dual-monitor-bug-on-the-context-menu
> 
> I managed to track it down to this JDK bug:
> 
> https://bugs.openjdk.org/browse/JDK-6415065
> 
> I've described the cause and the fix in the commit message, but in short, 
> what happens here is that `JMenu.getPopupMenuOrigin` sometimes returns 
> coordinates outside (usually above) of the current screen, and later 
> `JPopupMenu.adjustPopupLocationToFitScreen` uses those coordinates to fit the 
> entire popup menu into the screen, which goes wrong because at that point 
> it's no longer known which screen the menu was initially invoked on.
> 
> I've fixed this by making sure the Y coordinate is still within the correct 
> screen when it's returned from `JMenu.getPopupMenuOrigin`.

Looks reasonable to me. Clearly what's seen in the JB tracker is odd ..

-------------

Marked as reviewed by prr (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/15185#pullrequestreview-1636299935

Reply via email to