On Thu, 17 Aug 2023 21:37:17 GMT, Phil Race <p...@openjdk.org> wrote:
>> The private field `mask` is never used in `JFormattedTextField`. >> >> I couldn't find any usages of the field, including JNI. Therefore, it is >> safe to remove. > > Marked as reviewed by prr (Reviewer). > > @prrace could you confirm, please? No CSR is required to remove an unused > > private field from classes in Swing because the specification for Swing > > classes states, “Serialized objects of this class will not be compatible > > with future Swing releases.” > > I believe your approval means just that. I still want an additional > > confirmation to avoid any confusion. > > It is to resolve @mrserb's concern raised above. > > I haven't gotten any reply… > > The PR has two approvals now. If don't hear any objections, I'll integrate it > in a day or two. Swing isn't serializable across releases, so I see no need for a CSR. ------------- PR Comment: https://git.openjdk.org/jdk/pull/15088#issuecomment-1728353758
