On Mon, 25 Sep 2023 16:46:26 GMT, Alexander Zvegintsev <azveg...@openjdk.org>
wrote:
>> test/jdk/java/awt/Frame/FrameResizeTest/FrameResizeTest_1.java line 62:
>>
>>> 60: .build();
>>> 61:
>>> 62: SwingUtilities.invokeAndWait(() -> {
>>
>> Suggestion:
>>
>> EventQueue.invokeAndWait(() -> {
>>
>> Using `EventQueue` is more appropriate for AWT components.
>
> This particular case also uses the JFrame from PassFailJFrame.
> So I used the Swing variant here (which uses EventQueue.invokeAndWait
> internally).
Yeah, yet `JFrame` is hidden away inside `PassFailJFrame`.
The test itself uses AWT components, therefore it's reasonable not to use
`SwingUtilities`. Functionally, there's no change, so I'm nitpicking.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15787#discussion_r1336194944
