On Thu, 14 Sep 2023 21:45:31 GMT, Damon Nguyen <[email protected]> wrote:
>> Alexander Zuev has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Update test/jdk/javax/swing/AncestorNotifier/4817630/bug4817630.java >> >> Co-authored-by: Andrey Turbanov <[email protected]> >> - Update >> test/jdk/javax/swing/DefaultBoundedRangeModel/4297953/bug4297953.java >> >> Co-authored-by: Andrey Turbanov <[email protected]> > > test/jdk/javax/swing/AncestorNotifier/4817630/bug4817630.java line 112: > >> 110: test.start(); >> 111: } finally { >> 112: test.destroy(); > > Either destroy() or the if statement in destroy() for disposing the frame > should be on EDT Fixed. > test/jdk/javax/swing/BoxLayout/4191948/bug4191948.java line 76: > >> 74: frame.setVisible(false); >> 75: frame.dispose(); >> 76: } > > Should this if statement be run on EDT? In new version the entire method is being run on EDT. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/15702#discussion_r1336221059 PR Review Comment: https://git.openjdk.org/jdk/pull/15702#discussion_r1336220415
