On Tue, 10 Oct 2023 22:32:54 GMT, Phil Race <p...@openjdk.org> wrote:
>> Julian Waters has updated the pull request incrementally with five >> additional commits since the last revision: >> >> - Revert sspi.cpp >> - Revert NativeCreds.c >> - Revert allocation.cpp >> - Revert symbolengine.cpp >> - Revert os_windows.cpp > > make/autoconf/flags-cflags.m4 line 566: > >> 564: # compilation of all source files regardless of the active code >> page on Windows. >> 565: TOOLCHAIN_CFLAGS_JVM="-nologo -MD -Zc:preprocessor >> -Zc:strictStrings -Zc:inline -permissive- -utf-8 -MP" >> 566: TOOLCHAIN_CFLAGS_JDK="-nologo -MD -Zc:preprocessor >> -Zc:strictStrings -Zc:inline -permissive- -utf-8 -Zc:wchar_t-" > > Now you are splitting it, surely you can't include this option until the very > last PR ? > I don't see those other PRs. > Also the bug cat probably should now be "client-libs" .. I will update it .. > and you'll need to create new > linked bugs for the other PRs. The bug title needed to change too. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/15096#discussion_r1353503647
