On Wed, 11 Oct 2023 16:38:16 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:
>> Daniel Jeliński has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains four additional >> commits since the last revision: >> >> - Merge remote-tracking branch 'origin' into desktop-exports >> - Merge remote-tracking branch 'origin' into desktop-exports >> - Make J2dTraceInit static >> - Remove unnecessary exports > > src/java.desktop/share/native/libawt/java2d/SurfaceData.h line 557: > >> 555: */ >> 556: SurfaceDataOps * >> 557: SurfaceData_GetOpsNoSetup(JNIEnv *env, jobject sData); > > ~~It seems to me none of the functions in `SurfaceData.h` should be exported. > They all end up in `awt.dll` / `libawt.so`. I can't see any of these > functions are accessed from other DLLs.~~ > > ~~Would you like to create a separate task for removing exports from > `SurfaceData` functions?~~ > > Some are used from `fontmanager.dll`. But not as many as we export. > > Potentially all symbols exported from `awt.dll` except from `Java*` can be > hidden… > I found that `Disposer_AddRecord` and `J2dTraceImpl` are used from `lcms.dll`. Keep in mind that on Linux libawt is split into libawt, libawt_headless and libawt_xawt, and the export/import dependencies are different. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/13261#discussion_r1355472800
