On Tue, 31 Oct 2023 21:32:26 GMT, Daniel Jeliński <djelin...@openjdk.org> wrote:
> hb-subset and hb-style APIs are not used and not exported by libfontmanger. > We can cut the compilation time by not compiling the unused files. > > The added exclusions reduce the build time by ~1 minute (~8%) on my machine. > This is with harfbuzz 8, with harfbuzz 7 the improvement was ~30 seconds. > > Client libs tests continue to pass. OK, let's just go with the exclusion at least for now. If it becomes a problem on a subsequent upgrade it may need to be changed. We can also explore other options later. ------------- Marked as reviewed by prr (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/16440#pullrequestreview-1716521585