On Fri, 3 Nov 2023 21:06:07 GMT, Damon Nguyen <[email protected]> wrote:
>> Tejesh R has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Synth update
>
> test/jdk/javax/swing/JTable/JTableRightAlignmentTest.java line 64:
>
>> 62:
>> 63: public static void main(String[] args) throws Exception {
>> 64:
>> UIManager.setLookAndFeel("javax.swing.plaf.metal.MetalLookAndFeel");
>
> Should this test run on all L&F? Since part of the fix occurs in BasicTableUI.
I couldn't find a way to generalize the automatic test for all L&F, though I
tested all manually.
> test/jdk/javax/swing/JTable/JTableRightAlignmentTest.java line 121:
>
>> 119: private static void saveImage(BufferedImage image, String fileName)
>> {
>> 120: try {
>> 121: ImageIO.write(image, "png", new File(fileName));
>
> Is it OK to save an image here? In the past, I stored my images similar to in
> #7310 to store the image in the correct area for temporary images for a test.
U mean to create a test directory and store image there?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16374#discussion_r1384348542
PR Review Comment: https://git.openjdk.org/jdk/pull/16374#discussion_r1384349455
