On Tue, 7 Nov 2023 04:18:55 GMT, Tejesh R <[email protected]> wrote: >> Table contents does not follow right-left Orientation when Max width of >> columns are set. This is due to not considering the offset in `x position` >> while painting table grid and table cell. The fix handles the offset and >> adjust the x position for each paint, similar to how header is painted. The >> fix is applied to both Basic and Synth Look and Feel. >> The fix is verified for all Look and Feel manually and test verifies on >> Metal L&F since automatic test cannot be generalized throughout other Look >> and Feel. >> CI tested is green for regression check and test check. > > Tejesh R has updated the pull request incrementally with one additional > commit since the last revision: > > Review fix
src/java.desktop/share/classes/javax/swing/plaf/basic/BasicTableUI.java line 2106: > 2104: columnWidth = aColumn.getWidth(); > 2105: cellRect.width = columnWidth - columnMargin; > 2106: paintCell(g, cellRect, row, cMax); Is this code snippet required? It was not needed for LTR.. Guess we do the check in l2113 where we do paintCell for the same.. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16374#discussion_r1386327883
