On Tue, 14 Nov 2023 11:10:06 GMT, Prasanta Sadhukhan <[email protected]>
wrote:
>> Test was run without waiting for UI to be made visible leading to
>> IllegalComponentStateException.
>> Used robot.delay consistent with other headful tests to made the test wait
>> after UI is created and shown.
>>
>> Test passed in several iterations in all platforms. Link in JBS
>
> Prasanta Sadhukhan has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Optimize test
Looks good except for the minor comment.
test/jdk/javax/swing/JMenuItem/4654927/bug4654927.java line 79:
> 77: robot.delay(250);
> 78:
> 79: System.out.println("MenuItem LocationOnScreen " +
> menuItem.getLocationOnScreen());
Line 79 is redundant, it prints the same location that's printed on line 81.
-------------
Marked as reviewed by aivanov (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/15677#pullrequestreview-1730074554
PR Review Comment: https://git.openjdk.org/jdk/pull/15677#discussion_r1392817958
