On Mon, 20 Nov 2023 09:15:46 GMT, Prasanta Sadhukhan <[email protected]>
wrote:
>> Tejesh R has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review fix
>
> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicTableUI.java line
> 2101:
>
>> 2099: for (int row = rMin; row <= rMax; row++) {
>> 2100: cellRect = table.getCellRect(row, cMin, false);
>> 2101: cellRect.x = getXPosition(cMax);
>
> Is this not a problem that `cellRect` is calculated for `cMin` but
> `cellRect.x` is calculated for `cMax` which means `cellRect.y` would be of
> `cMin` column but `cellRect.x` would be of `cMax` column. SImilarly for the
> `cellRect.width`...You probably can get away maybe because usually all cells
> have same width but I guess it will be a problem if different cells have
> different width...Please check..
Yeah, seems logical. It must `cMax`.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16374#discussion_r1398941524
