On Wed, 9 Aug 2023 06:35:08 GMT, Thomas Stuefe <stu...@openjdk.org> wrote:
>> Julian Waters has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 22 additional >> commits since the last revision: >> >> - Mismatched declaration in D3DGlyphCache.cpp >> - Fields in awt_TextComponent.cpp >> - reinterpret_cast needed in AccessBridgeJavaEntryPoints.cpp >> - Qualifiers in awt_PrintDialog.h should be removed >> - Likewise for awt_DnDDT.cpp >> - awt_ole.h include order issue in awt_DnDDS.cpp >> - Revert awt_ole.h >> - Earlier fix in awt_ole.h was not complete >> - Merge branch 'openjdk:master' into patch-10 >> - Likewise for awt_Frame.cpp >> - ... and 12 more: https://git.openjdk.org/jdk/compare/adf193c5...51230f3d > > src/java.desktop/windows/native/libawt/windows/awt_Frame.cpp line 1641: > >> 1639: } >> 1640: } >> 1641: > > A possible improvement later (and for a future RFE) would be to use RAII for > deletion and then get rid of the labels. awt is one of the few places that > uses C++ for native code, so why not. Phil unfortunately rejected that approach, so we're on to a more manual way of deleting things here ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/15096#discussion_r1413137761
