On Tue, 5 Dec 2023 06:26:03 GMT, Alisen Chung <[email protected]> wrote:

>> Added delays to stabilize test, test passes 50 times consecutively
>
> Alisen Chung has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   updated test

test/jdk/java/awt/Window/Grab/GrabTest.java line 122:

> 120:             f.setVisible(true);
> 121:             w.setVisible(true);
> 122:             robot.delay(500);

This delay blocks the UI thread because it is called on EDT.
It should be called outside of the `SwingUtilities.invokeAndWait` block, e.g. 
before the `test()` call.

There are also other `setVisible` calls in this test that require similar delay.
Especially in cases where we try to click on a component right after showing a 
frame.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16867#discussion_r1414960840

Reply via email to