On Tue, 5 Dec 2023 19:41:54 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:
>> Phil Race has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8320443 > > test/jdk/java/awt/print/PrinterJob/PrinterDevice.java line 52: > >> 50: public class PrinterDevice implements Printable { >> 51: >> 52: static volatile boolean failed = false; > > Is it really needed? In all the cases where you assign `true` to the `failed` > field, you also explicitly throw an exception, which is enough to fail the > test. It is to test the "the macOS printing implementation was swallowing exceptions it should not." ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16773#discussion_r1416221561