On Wed, 6 Dec 2023 13:18:53 GMT, Tejesh R <t...@openjdk.org> wrote: >>> Instead of passing the laf through all the methods, can't we create and use >>> a class variable? >> >> Can be done but can't see any functional improvements. This seems ok to me. > > Yeah, those are to reduce redundancy in code, not functional...... Otherwise > the fix looks fine.
It's not redundancy: passing the `laf` explicitly makes the data flow clearer, even though `laf` isn't directly used. I agree that making `laf` a class field doesn't provide much benefit. In a way, it could be removed completely, however, reporting the L&F at which the test case failed gives more details, you don't need to look at the test log to find the L&F. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16674#discussion_r1417416141
