On Tue, 2 Jan 2024 03:53:06 GMT, Renjith Kannath Pariyangad
<[email protected]> wrote:
>> Hi Reviewers,
>> There was a typo for color conversion instead of dstColorSpace function
>> srcColorSpace was used. Please review and let me know your suggestions if
>> any.
>>
>> Renjith.
>
> Renjith Kannath Pariyangad has updated the pull request incrementally with
> one additional commit since the last revision:
>
> Removed unnecessary try block
test/jdk/java/awt/color/NonICCFilterTest.java line 47:
> 45:
> 46: protected TestColorSpace(boolean bSrc) {
> 47: super(CS_sRGB, 3);
CS_sRGB is not a constant of the ColorSpace type, the
ICC_Profile.getInstance(xx).getColorSpaceType() and profile.getNumComponents()
should be used.
test/jdk/java/awt/color/NonICCFilterTest.java line 53:
> 51:
> 52: public float[] toRGB(float[] colorvalue) {
> 53: return colorvalue;
Just for completeness, it is probably better to use csRGB.toRGB and
csRGB.fromRGB in these two methods
test/jdk/java/awt/color/NonICCFilterTest.java line 109:
> 107: throw new RuntimeException("Test failed: Source equal to
> Destination");
> 108: }
> 109: }
The "}" is missing in the latest version.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16895#discussion_r1439162717
PR Review Comment: https://git.openjdk.org/jdk/pull/16895#discussion_r1439163073
PR Review Comment: https://git.openjdk.org/jdk/pull/16895#discussion_r1439163248
