On Thu, 4 Jan 2024 06:14:49 GMT, Sergey Bylokhov <[email protected]> wrote:
>> @mrserb, Thank you for bringing this up. Sorry I am not pretty clear about >> your suggestion on _Conversion via TestColorSpace wrapper vs ColorSpace w/o >> wrapper._ . In existing code `compareImages` (pixel value compare) function >> is local, are you suggesting to move this into wrapper? > > Your `TestColorSpace` class is a wrapper on top of the actual color space. So > you can compare the results of conversion using `TestColorSpace` vs using > "actual color space" directly. @mrserb With your code above, I get `ArrayIndexOutOfBoundsException`. Do you mean to say there are two additional bugs? 1. `ArrayIndexOutOfBoundsException` is thrown; 2. Even regular ICC_Profile result in unexpected behaviour. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16895#discussion_r1442039232
