On Thu, 4 Jan 2024 13:05:42 GMT, Renjith Kannath Pariyangad
<rkannathp...@openjdk.org> wrote:
>> Hi Reviewers,
>> There was a typo for color conversion instead of dstColorSpace function
>> srcColorSpace was used. Please review and let me know your suggestions if
>> any.
>>
>> Renjith.
>
> Renjith Kannath Pariyangad has updated the pull request incrementally with
> one additional commit since the last revision:
>
> Copyright year updated
It looks good to me.
The current test fails without the fix in `ColorConvertOp` and passes with the
fix. Thus, the current bug is fixed and the regression test does its job.
It's good that further bugs have been identified, these are to be submitted and
then fixed. When the bugs are fixed, the test may be modified to test other
conditions, provided it still verifies this changeset.
test/jdk/java/awt/color/NonICCFilterTest.java line 108:
> 106: public static void main(String[] args) {
> 107:
> 108: BufferedImage src = createTestImage(true);
Suggestion:
public static void main(String[] args) {
BufferedImage src = createTestImage(true);
Remove the blank line at the start of the `main` method.
-------------
Marked as reviewed by aivanov (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/16895#pullrequestreview-1804631569
PR Review Comment: https://git.openjdk.org/jdk/pull/16895#discussion_r1442041375
