On Mon, 8 Jan 2024 04:06:09 GMT, Prasanta Sadhukhan <[email protected]>
wrote:
>> Tejesh R has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review Fix
>
> test/jdk/javax/swing/JTable/KeyBoardNavigation.java line 194:
>
>> 192:
>> 193: public static void main(String[] args) throws Exception {
>> 194:
>> UIManager.setLookAndFeel("javax.swing.plaf.metal.MetalLookAndFeel");
>
> The fix is for all L&F but the test is testing only Metal...It should be
> given chance to use default L&F in each platform..
> If 4112270 is only about Metal, then a new test should be spawned to test
> this fix for all fixed L&F..
4112270 is not only about Metal L&F. In Aqua L&F the functionality is
different, it enables the cell to edit mode. Yet, in macos excel functionality
is same as that of windows. Should we update Aqua too?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17236#discussion_r1444174136
