On Wed, 10 Jan 2024 05:56:37 GMT, Prasanta Sadhukhan <[email protected]>
wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove whitespace error
>
> src/java.desktop/share/classes/javax/swing/plaf/synth/SynthTreeUI.java line
> 837:
>
>> 835: }
>> 836: else {
>> 837: SynthGraphicsUtils.paintIcon(collapsedIcon, context, g,
>> x, y, w, h);
>
> Guess it's a copy of `ExpandedIconWrapper `class, so `CollapsedIconWrapper
> `and `ExpandedIconWrapper` can be optimised to use common method passing in
> the "icon" argument..
Should I merge the two classes into one class like instead of separate
`ExpandedIconWrapper` and `CollapsedIconWrapper`, only one `IconWrapper` class?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17294#discussion_r1447033548
