On Fri, 12 Jan 2024 09:53:46 GMT, Renjith Kannath Pariyangad <[email protected]> wrote:
>> Hi Reviewers, >> There was a typo for color conversion instead of dstColorSpace function >> srcColorSpace was used. Please review and let me know your suggestions if >> any. >> >> Renjith. > > Renjith Kannath Pariyangad has updated the pull request incrementally with > one additional commit since the last revision: > > Included wrapper check The diffs are rather long above, this is how the `main` method should look like: https://github.com/aivanov-jdk/jdk/blob/e3f9b66089311949d5ff99a77511e309219247ba/test/jdk/java/awt/color/NonICCFilterTest.java#L128-L150 That is a `gold` color converter is created with the plain `ICC_ColorSpace` and it's applied to both images. Next, a `test` color converter is created with the wrapper and again it's applied to both images. ------------- PR Comment: https://git.openjdk.org/jdk/pull/16895#issuecomment-1889960387
