On Tue, 19 Dec 2023 02:09:08 GMT, songpv-imt <d...@openjdk.org> wrote:

>> The root cause of the bug is because mousePress() method is invoked before 
>> mouseMove() event is completely processed causing the drag & drop behavior 
>> not being able to be recognized properly. This in turn makes the method 
>> dragSourceListener.isDropFinished() returns false and fail the test. To fix 
>> this, setAutoWaitForIdle(true) and Thread.Sleep is called to make sure the 
>> mouseMove() event is processed completely before moving to execute the 
>> mousePress() method.
>> 
>> JBS issue: [JDK-8317287](https://bugs.openjdk.org/browse/JDK-8317287)
>
> songpv-imt has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Update InterJVMGetDropSuccessTest.java
>   - Update success1 and success2 to volatile

Changes requested by aivanov (Reviewer).

test/jdk/java/awt/dnd/InterJVMGetDropSuccessTest/InterJVMGetDropSuccessTest.java
 line 1:

> 1: /*

GitHub doesn't allow leaving comments to unmodified lines therefore I'm leaving 
a file comment:

1. Please organise imports: use per-class imports instead of wildcard imports.
2. Use Java-style array declaration for `successCodes` and declare it as 
`final` to resolve IDE warnings.
3. Remove unused `successCodes` field and `reset` method.
4. Remove unused `pointInComponent` and `pointInComponentImpl` methods.

-------------

PR Review: https://git.openjdk.org/jdk/pull/16396#pullrequestreview-1822311145
PR Review Comment: https://git.openjdk.org/jdk/pull/16396#discussion_r1452779145

Reply via email to