On Sat, 20 Jan 2024 10:15:02 GMT, Sam James <d...@openjdk.org> wrote:
> This fixes building with GCC 14: > * Cherry-pick a fix from Harfbuzz upstream > * Apply other `-Wcalloc-transposed-args` fixes to the JDK sources > > -Wcalloc-transposed-args errors out with GCC 14 as the OpenJDK build uses > -Werror. > > The calloc prototype is: > > void *calloc(size_t nmemb, size_t size); > > > So, just swap the number of members and size arguments to match the > prototype, as > we're initialising 1 struct of size `sizeof(struct ...)`. GCC then sees we're > not > doing anything wrong. ok - if I have to drop it, so be it, not the end of the world. I guess it's also tricky because of cherry-picking one change vs bumping to some git commit upstream as a whole. I'll wait a little bit then just drop if nobody chimes in. Thank you! Would you be so kind to file one for me please? I don't have access yet. ------------- PR Comment: https://git.openjdk.org/jdk/pull/17506#issuecomment-1902514432 PR Comment: https://git.openjdk.org/jdk/pull/17506#issuecomment-1902516320
