On Thu, 25 Jan 2024 04:33:25 GMT, Tejesh R <[email protected]> wrote:

> > Even if you'll go this route, I'm for replacing `Vector` with `ArrayList` 
> > for the `newFileCache` and `newFiles` variables. These are local variables, 
> > they're not accessed concurrently. Yet they're accessed from two threads: 
> > the current one and the one where `ShellFolder.invoke` runs, so there could 
> > be a need to use another synchronisation technique to ensure thread-safety 
> > between these two threads.
> 
> Another Synchronization technique even after `synchronized (fileCache)`?

Yes, even after.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17462#discussion_r1466117839

Reply via email to