On Tue, 30 Jan 2024 13:47:05 GMT, Tejesh R <t...@openjdk.org> wrote: >> Suggested fix [JDK-8307091](https://bugs.openjdk.org/browse/JDK-8307091) >> also created concurrent exception intermittently (monthly once/quarterly >> once) on CI system. The issue was not able to be reproduced yet, hence >> proposing an alternative fix which uses iterators to compare the List. >> CI testing shows green. > > Tejesh R has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelated changes brought in > by the merge/rebase. The pull request contains five additional commits since > the last revision: > > - Review updates - Indentatioins and unused imports > - Merge branch 'master' of https://git.openjdk.java.net/jdk into > branch_8323670 > - Revert fix 8307091 + Synchronised filecache > - Merge branch 'master' of https://git.openjdk.java.net/jdk into > branch_8323670 > - Fix
Looks good to me. I cannot get `ConcurrentModificationException` when running my test, `BasicDirectoryModelConcurrency.java`, on a build with the fix. ------------- Marked as reviewed by aivanov (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/17462#pullrequestreview-1851418580
