On Mon, 29 Jan 2024 20:45:18 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:
>> Christoph Langer has updated the pull request with a new target base due to >> a merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains six additional >> commits since the last revision: >> >> - Move Exception Check to the right place >> - Merge branch 'master' into JDK-8323664 >> - Changes to assertion function and test as discussed >> - Revert "JDK-8323664" >> >> This reverts commit 32128744252d75104e0d19f5eb701ffdc7b3d417. >> - Merge branch 'master' into JDK-8323664 >> - JDK-8323664 > > test/jdk/java/awt/font/JNICheck/FreeTypeScalerJNICheck.java line 48: > >> 46: ProcessBuilder pb = >> ProcessTools.createTestJavaProcessBuilder("-Xcheck:jni", >> FreeTypeScalerJNICheck.class.getName(), "runtest"); >> 47: OutputAnalyzer oa = ProcessTools.executeProcess(pb); >> 48: >> oa.shouldContain("Done").shouldNotContain("WARNING").shouldNotContain("AWT >> Assertion").shouldHaveExitValue(0); > > Maybe wrap each condition to its own line? > Suggestion: > > oa.shouldContain("Done") > .shouldNotContain("WARNING") > .shouldNotContain("AWT Assertion") > .shouldHaveExitValue(0); > > This way each verified condition stands out. Done. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/17404#discussion_r1472342402