On Wed, 31 Jan 2024 17:13:55 GMT, Alexey Ivanov <[email protected]> wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Optimise test
>
> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicTreeUI.java line
> 3284:
>
>> 3282: if(tree != null) {
>> 3283: rendererPane.removeAll();
>> 3284: // Only ever removed when UI changes, this is OK!
>
> The comment no longer applies—you remove all the components from
> `rendererPane` on the line above.
This is the only important thing that prevents me from approving this PR. The
comment is misleading now.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17458#discussion_r1473193899
