On Fri, 9 Feb 2024 10:52:54 GMT, Prasanta Sadhukhan <[email protected]>
wrote:
>> When `<s>` tag is used inside `<u>`, the `line-through` style is lost, and
>> the text is rendered with `underline` only. However, if `<strike>` is used,
>> the text is rendered with both `underline` and `line-through` styles.
>>
>> Both `<s>` and `<strike>` should render the text the same way.
>
> test/jdk/javax/swing/text/html/HTMLDocument/HTMLStrike.java line 84:
>
>> 82: if (!errors.isEmpty()) {
>> 83: errors.delete(errors.length() - 2, errors.length());
>> 84: throw new Error(errors + " must have both "
>
> Should it be RuntimeException inline with other tests?
`Error` is shorter and conveys the reason better.
If you insist, I can use `RuntimeException`.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17659#discussion_r1484393265
