On Thu, 15 Feb 2024 09:17:34 GMT, Abhishek Kumar <[email protected]> wrote:
>> JTabbedPane's content area, tab area and tab background color are not as >> expected when opaque is set to true or false. >> The proposed fix is to handle the TabbedPane's background color in installed >> LAFs. Manual test is added to support the fix and there is no regression >> caused by the fix. >> >> Proposed fix is tested in Ubuntu 22.04 and Oracle linux. >> >> CI link is posted in JBS. > > Abhishek Kumar has updated the pull request incrementally with one additional > commit since the last revision: > > Remove WindowsLAF check src/java.desktop/share/classes/com/sun/java/swing/plaf/gtk/GTKLookAndFeel.java line 1024: > 1022: "TabbedPane.font", new FontLazyValue(Region.TABBED_PANE), > 1023: "TabbedPane.selectedTabPadInsets", new InsetsUIResource(2, > 2, 0, 1), > 1024: "TabbedPane.selected", tabbedPaneBg, `TabbedPane.selected` already existed or newly added ? If newly added then it would be better to name it as `SelectedColor` or something similar. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/17720#discussion_r1498649144
