On Wed, 21 Feb 2024 22:45:17 GMT, Brent Christian <bchri...@openjdk.org> wrote:
>> Per Minborg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Suppress restricted warning
>
> src/java.desktop/unix/classes/sun/awt/X11/XEmbeddingContainer.java line 150:
>
>> 148: }
>> 149: } finally {
>> 150: Reference.reachabilityFence(data);
>
> Can you explain the need for this `reachabilityFence()`? I don't understand
> how `data` could become unreachable before the `Arena` is closed. Also, it's
> an in-scope local variable. Thanks!
You are right. As we have the arena, we do not need to invoke the
reachabilityFence.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17846#discussion_r1499530743
