On Mon, 4 Mar 2024 06:33:09 GMT, Renjith Kannath Pariyangad <rkannathp...@openjdk.org> wrote:
>> Hi Reviewers, >> >> Updated manual printer test cases with 'PassFailJFrame', also removed unused >> variables. Added 'SkippedException' in case of printer missing or not >> configured. >> >> Please review and let me know your suggestions. >> >> Regards, >> Renjith > > Renjith Kannath Pariyangad has updated the pull request incrementally with > one additional commit since the last revision: > > Updated instruction The usage of split UI makes printer tests nicer. I think all printer tests should have a Print button or the like to start testing rather than starting a print job right away. I find such tests easier to use. The instructions appear, you have the time to read through them and then click Print to start testing. In this case, if you clicked Cancel in the print dialog, you can click the Print button in the UI again to retry. However, it is not a goal at this time… a suggestion for a future improvement. ------------- PR Comment: https://git.openjdk.org/jdk/pull/17608#issuecomment-1978922032
