On Tue, 5 Mar 2024 12:13:02 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:
>> Renjith Kannath Pariyangad has updated the pull request incrementally with >> one additional commit since the last revision: >> >> Suggesions incorporated > > test/jdk/java/awt/print/PrinterJob/PrintAllFonts.java line 45: > >> 43: private static final int FONT_SIZE = 14; >> 44: private final Font[] allFonts = >> 45: >> GraphicsEnvironment.getLocalGraphicsEnvironment().getAllFonts(); > > I suggest adding blank lines to visually separate fields / constants with > different purpose. > Suggestion: > > private static final int LINE_HEIGHT = 18; > private static final int FONT_SIZE = 14; > > private final Font[] allFonts = > GraphicsEnvironment.getLocalGraphicsEnvironment().getAllFonts(); What about this? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/17607#discussion_r1514715232
