On Tue, 5 Mar 2024 03:49:01 GMT, Sergey Bylokhov <s...@openjdk.org> wrote:
>> test/jdk/sun/java2d/cmm/ColorConvertOp/ColConvCCMTest.java line 63: >> >>> 61: 10.5, // GRAY >>> 62: 215.0, // PYCC >>> 63: 56.0 // CIEXYZ >> >> All this change will delete all information about "old and good" values and >> start to use lcms thresholds for all profiles? I think it should be the >> opposite - use the good data for all except lcms(or any other not that good >> as jdk8 profiles), like we do it now. > > Actually the purpose of these particular tests is validation of the quality > of the built-in color profiles. I agree, I reverted almost all changes except the ones in tolerance for non-LCMS profiles. That values need to be updated to make the test pass on JDKs (e.g. JDK 8u, etc) where non-LCMS profiles are used ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18097#discussion_r1516077519
