On Wed, 6 Mar 2024 21:36:10 GMT, Alisen Chung <ach...@openjdk.org> wrote:
>> Root cause of the test failure was fixed with >> https://bugs.openjdk.org/browse/JDK-8316931, updating this test since the >> other fix also included a test update. > > Alisen Chung has updated the pull request incrementally with one additional > commit since the last revision: > > null check for system tray before remove test/jdk/java/awt/TrayIcon/DisposeInActionEventTest/DisposeInActionEventTest.java line 63: > 61: " (also called Taskbar Status Area on MS Windows, > Notification\n" + > 62: " Area on Gnome or System Tray on KDE) is > visible.\n\n" + > 63: clickInstruction + " the button on the tray icon > to trigger the\n" + What I see on Windows: “Double click _the button_ on the tray icon to trigger the…” What button do I need to click? test/jdk/java/awt/TrayIcon/DisposeInActionEventTest/DisposeInActionEventTest.java line 65: > 63: clickInstruction + " the button on the tray icon > to trigger the\n" + > 64: " action event. Brief information about action > events is printed\n" + > 65: " in the frame. After each action event the tray > icon is removed from\n" + Suggestion: " in the frame. After each action event, the tray icon is removed from\n" + test/jdk/java/awt/TrayIcon/DisposeInActionEventTest/DisposeInActionEventTest.java line 68: > 66: " the tray and then added back in a second.\n\n" + > 67: "The test performs some automatic checks when > removing the icon. If\n" + > 68: " something is wrong the corresponding message > the test will automatically fail.\n" + Suggestion: " something is wrong, the test will automatically fail.\n" + test/jdk/java/awt/TrayIcon/DisposeInActionEventTest/DisposeInActionEventTest.java line 70: > 68: " something is wrong the corresponding message > the test will automatically fail.\n" + > 69: " Repeat clicks several times. If no 'Test > FAILED' messages\n" + > 70: " are printed, press PASS button else FAIL > button."; Suggestion: "\n" + "Repeat clicks several times. Press PASS button."; Perhaps, the instructions need to be re-worked further. The tester needs to perform the action several times. The test will fail automatically if anything's wrong. If it doesn't, press the Pass button. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/17838#discussion_r1516286794 PR Review Comment: https://git.openjdk.org/jdk/pull/17838#discussion_r1516287544 PR Review Comment: https://git.openjdk.org/jdk/pull/17838#discussion_r1516288497 PR Review Comment: https://git.openjdk.org/jdk/pull/17838#discussion_r1516295653
