On Mon, 11 Mar 2024 10:02:21 GMT, Prasanta Sadhukhan <[email protected]>
wrote:
> Conversion of manual applet test to main based using PassFailJFrame manual
> framework
Changes requested by aivanov (Reviewer).
test/jdk/javax/swing/JInternalFrame/6726866/bug6726866.java line 51:
> 49:
> 50: public static void main(String[] args) throws Exception {
> 51: PassFailJFrame passFailJFrame = new PassFailJFrame.Builder()
Please use the `builder` helper method instead of using `new` explicitly.
test/jdk/javax/swing/JInternalFrame/6726866/bug6726866.java line 54:
> 52: .title("JInternalFrame Instructions")
> 53: .instructions(instructionsText)
> 54: .testTimeOut(5)
The default timeout can be omitted.
-------------
PR Review: https://git.openjdk.org/jdk/pull/18186#pullrequestreview-1927995890
PR Review Comment: https://git.openjdk.org/jdk/pull/18186#discussion_r1519859043
PR Review Comment: https://git.openjdk.org/jdk/pull/18186#discussion_r1519820170
